You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/28 21:18:52 UTC

[GitHub] [airflow] pierrejeambrun opened a new pull request, #26762: Allow retrieving error message from data.detail

pierrejeambrun opened a new pull request, #26762:
URL: https://github.com/apache/airflow/pull/26762

   When testing edge cases for https://github.com/apache/airflow/pull/26457 I noticed that the toast error would not properly be displayed when the api response returns any error derived from a `ProblemException`. This would end up in an unhandled exception in the UI.
   
   > Note: Certain endpoint like `/run` can return just a text when there is an error, so we need to keep the `error.response?.data` in case `data` is plain text and not an object.
   
   ### Before
   ![image](https://user-images.githubusercontent.com/14861206/192890426-093067d3-0fc9-4796-a162-3e109aa07bf4.png)
   
   ### After
   ![image](https://user-images.githubusercontent.com/14861206/192890606-173efd04-c989-4d14-ae34-6ddf75a12958.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #26762: Allow retrieving error message from data.detail

Posted by GitBox <gi...@apache.org>.

bbovenzi merged PR #26762:
URL: https://github.com/apache/airflow/pull/26762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Jorricks commented on pull request #26762: Allow retrieving error message from data.detail

Posted by GitBox <gi...@apache.org>.

Jorricks commented on PR #26762:
URL: https://github.com/apache/airflow/pull/26762#issuecomment-1261857162

   Nice work @pierre!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org