You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "singular-seal (via GitHub)" <gi...@apache.org> on 2024/03/14 03:35:14 UTC
[I] need support for readonly command [kvrocks]
singular-seal opened a new issue, #2166:
URL: https://github.com/apache/kvrocks/issues/2166
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Motivation
1. redis cluster utilize [readonly](https://redis.io/commands/readonly/) to support reading from slave node
2. go-redis will send a 'readonly' command to server when 'ReadOnly' option is true during initialisation which would incur an error response from kvrocks 'ERR unknown command readonly' because kvrocks doesn't support command 'readonly'
3. this is important because without reading from slave a shard is not readable during failover which is not acceptable for some businesses
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] need support for readonly command [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #2166:
URL: https://github.com/apache/kvrocks/issues/2166#issuecomment-1996334255
@singular-seal Thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support of the command READONLY & READWRITE [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on issue #2166:
URL: https://github.com/apache/kvrocks/issues/2166#issuecomment-1999456220
Hi @LiuYuHui.
You can add a flag in `redis::Connection` to store if this connection enables read queries.
You can add new commands in [cmd_server.cc](https://github.com/apache/kvrocks/blob/unstable/src/commands/cmd_server.cc)
The following code may be the code you need to modify.
- https://github.com/apache/kvrocks/blob/unstable/src/cluster/cluster.cc#L804-L807
If you have any other questions, feel free to ask me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support of the command READONLY & READWRITE [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #2166:
URL: https://github.com/apache/kvrocks/issues/2166#issuecomment-1999234360
@LiuYuHui Thank you! Go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support of the command READONLY & READWRITE [kvrocks]
Posted by "LiuYuHui (via GitHub)" <gi...@apache.org>.
LiuYuHui commented on issue #2166:
URL: https://github.com/apache/kvrocks/issues/2166#issuecomment-1999231302
Hi @git-hulk, I want to help implement this feature, could you give me some suggestions on where to start? thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support of the command READONLY & READWRITE [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #2166: Add support of the command READONLY & READWRITE
URL: https://github.com/apache/kvrocks/issues/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org