You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 14:36:45 UTC
[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1632: Update clap requirement from 2.33 to 3.0
dependabot[bot] opened a new pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632
Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p>
<blockquote>
<h2>v3.0.10</h2>
<h2>[3.0.10] - 2022-01-18</h2>
<h3>Fixes</h3>
<ul>
<li>Resolve <code>panic!</code> from v3.0.8 when using <code>global_setting(PropagateVersion)</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p>
<blockquote>
<h2>[3.0.10] - 2022-01-18</h2>
<h3>Fixes</h3>
<ul>
<li>Resolve <code>panic!</code> from v3.0.8 when using <code>global_setting(PropagateVersion)</code>.</li>
</ul>
<h2>[3.0.9] - 2022-01-17</h2>
<h3>Features</h3>
<ul>
<li>Added <code>App::find_subcommand_mut</code></li>
</ul>
<h2>[3.0.8] - 2022-01-17</h2>
<h3>Fixes</h3>
<ul>
<li>Respected <code>DisableColoredHelp</code> on <code>cmd help help</code></li>
<li>Provide a little more context when completing arguments for <code>cmd help</code></li>
<li>Provide more context for some asserts</li>
<li>Small documentation improvements</li>
</ul>
<h2>[3.0.7] - 2022-01-12</h2>
<h3>Fixes</h3>
<ul>
<li>Shift more asserts from parsing to <code>App</code> building (ie will now run in <code>App::debug_assert</code>)</li>
</ul>
<p><strong>derive</strong></p>
<ul>
<li>Documentation fixes</li>
</ul>
<h2>[3.0.6] - 2022-01-10</h2>
<h3>Fixes</h3>
<p><strong>derive</strong></p>
<ul>
<li>Don't assume user does <code>use clap::ArgEnum</code> (<a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3277">#3277</a>)</li>
<li>Documentation fixes</li>
</ul>
<h2>[3.0.5] - 2022-01-05</h2>
<h3>Fixes</h3>
<ul>
<li>Provide hack to workaround <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3263">inability to detect external subcommands aliasing when escaped</a> (<a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3264">#3264</a>)</li>
</ul>
<p><strong>docs:</strong></p>
<ul>
<li>Cleaned up code blocks in tutorials (<a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3261">#3261</a>)</li>
<li>Clean up quotes in <code>ArgMatches</code> asserts</li>
<li>List correct replacement for deprecated <code>Parser::from_clap</code> (<a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3257">#3257</a>)</li>
</ul>
<h2>[3.0.4] - 2022-01-04</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/clap-rs/clap/commit/5877f884f17af99937f91ebb065179faacd65378"><code>5877f88</code></a> chore: Release</li>
<li><a href="https://github.com/clap-rs/clap/commit/8cfa3567ef638255ce34abfcc05029f71c0bb98c"><code>8cfa356</code></a> docs: Update changelog</li>
<li><a href="https://github.com/clap-rs/clap/commit/c6b5f640a4ba883ef700425ecfae0173a307a9df"><code>c6b5f64</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3311">#3311</a> from epage/fix</li>
<li><a href="https://github.com/clap-rs/clap/commit/38e6952d4687ac04645c97ecad31833d98838611"><code>38e6952</code></a> fix: Don't panic when propagating</li>
<li><a href="https://github.com/clap-rs/clap/commit/4b60440d91c02a472e31e66117c34b0fc9e6d09a"><code>4b60440</code></a> docs: Note case in <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3309">#3309</a></li>
<li><a href="https://github.com/clap-rs/clap/commit/bd1bf66279c3e965a0d4d73135d952bfd3c270eb"><code>bd1bf66</code></a> chore: Release</li>
<li><a href="https://github.com/clap-rs/clap/commit/4e51f9b0efa39e71b92ced0bdfa30a0b39107f52"><code>4e51f9b</code></a> docs: Update changelog</li>
<li><a href="https://github.com/clap-rs/clap/commit/784d249a4ee12f4742c27e7a620a055e9b673121"><code>784d249</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/clap-rs/clap/issues/3306">#3306</a> from sunshowers/sub</li>
<li><a href="https://github.com/clap-rs/clap/commit/236ec973d95e02c8440ee0da6e6c5713389ffc71"><code>236ec97</code></a> feat: Implement App::find_subcommand_mut</li>
<li><a href="https://github.com/clap-rs/clap/commit/ccbbba8908ac30114345a26ccba227326c0ec73d"><code>ccbbba8</code></a> chore: Release</li>
<li>Additional commits viewable in <a href="https://github.com/clap-rs/clap/compare/clap_generate-v3.0.0-rc.0...v3.0.10">compare view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] longwusha commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
longwusha commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790276052
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
Why somewhere we get clap = "3" but otherwhere we get clap = "3.0" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790179174
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
probably because they removed `crate_version` from the public api in 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#issuecomment-1020488594
Thanks for looking into this @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790154552
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
I can understand why I got the error
```
➜ datafusion-cli git:(update_dep) ✗ cargo build
Compiling clap v3.0.10
Compiling datafusion-cli v5.1.0 (/Users/bytedance/arrow-datafusion/datafusion-cli)
error[E0432]: unresolved import `clap::crate_version`
--> datafusion-cli/src/main.rs:18:12
|
18 | use clap::{crate_version, App, Arg};
| ^^^^^^^^^^^^^ no `crate_version` in the root
error: cannot determine resolution for the macro `crate_version`
--> datafusion-cli/src/main.rs:36:18
|
36 | .version(crate_version!())
| ^^^^^^^^^^^^^
|
= note: import resolution is stuck, try simplifying macro imports
For more information about this error, try `rustc --explain E0432`.
error: could not compile `datafusion-cli` due to 2 previous errors
```
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#issuecomment-1020488623
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#issuecomment-1020488594
Thanks for looking into this @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790277440
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
This is dependabot's behavior, I haven't studied it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790318306
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
probably a bug in dependabot, in cargo, `3` is the same as `3.0` semantically when it comes to versioning pinning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790318306
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
probably a bug in dependabot. That said, in cargo, `3` is the same as `3.0` semantically when it comes to versioning pinning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#issuecomment-1020488623
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#issuecomment-1020182884
I filed an issue https://github.com/apache/arrow-datafusion/issues/1666 to track the ticket, so the ticket can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0
Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1632:
URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r792528527
##########
File path: datafusion-cli/Cargo.toml
##########
@@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"
rust-version = "1.58"
[dependencies]
-clap = "2.33"
+clap = "3.0"
Review comment:
```
#[cfg(feature = "cargo")]
#[macro_export]
macro_rules! crate_version {
() => {
env!("CARGO_PKG_VERSION")
};
}
```
I know the reason, we should use the 'cargo' feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org