[GitHub] [gobblin] aditya-narain-gupta commented on a change in pull request #3475: [GOBBLIN-1617] pass configurations to some HadoopUtils APIs

[GitBox <gi...@apache.org>]

aditya-narain-gupta commented on a change in pull request #3475:
URL: https://github.com/apache/gobblin/pull/3475#discussion_r820058818



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/FsDataWriter.java
##########
@@ -96,7 +97,7 @@ public FsDataWriter(FsDataWriterBuilder<?, ?> builder, State properties) throws
     this.writerAttemptIdOptional = Optional.fromNullable(builder.getWriterAttemptId());
     this.encoders = builder.getEncoders();
 
-    Configuration conf = new Configuration();
+    this.conf = new Configuration();

Review comment:
       We can populate the conf object with the properties passed in the constructor so that users can pass on custom configs like for Trash / File System-
   `this.conf = HadoopUtils.getConfFromProperties(properties);`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org