You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/13 10:09:44 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
lhotari opened a new pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572
### Motivation
BacklogQuotaManagerTest is flaky.
### Modifications
- use Awaitility for checking PersistentTopicInternalStats in a few test methods
- disable batching in all producers
- cleanup test by using the TIME_TO_CHECK_BACKLOG_QUOTA constant
- speed up test by reducing TIME_TO_CHECK_BACKLOG_QUOTA from 5 seconds to 3 seconds
- fix race condition in testConsumerBacklogEvictionWithAckTimeQuota which was causing flakiness
- resolve the race by pausing for 1 second after acknowledging 10 messages for the 1. consumer. This makes the ledgers to expire at different times so that the last ledger with 4 messages will expire later than others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840516778
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840558143
it looks like that the test you wanted to fix failed on CI
https://github.com/apache/pulsar/pull/10572/checks?check_run_id=2575259667

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840516778
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10572: [Tests] Reduce flakiness of BacklogQuotaManagerTest
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10572:
URL: https://github.com/apache/pulsar/pull/10572#issuecomment-840661374
> it looks like that the test you wanted to fix failed on CI
@eolivelli Thanks for pointing that out. I made some more changes in the PR to address flakiness. In particular, there was a challenge with the backlog size which seems to be off by one in some cases. I added some comments in the changes about it. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org