You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/06 19:16:51 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request #493: IGNITE-16067 Fix JMH benchmarks in the raft module
sashapolo opened a new pull request #493:
URL: https://github.com/apache/ignite-3/pull/493
https://issues.apache.org/jira/browse/IGNITE-16067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a change in pull request #493: IGNITE-16067 Fix JMH benchmarks in the raft module
Posted by GitBox <gi...@apache.org>.
sashapolo commented on a change in pull request #493:
URL: https://github.com/apache/ignite-3/pull/493#discussion_r763809388
##########
File path: modules/raft/pom.xml
##########
@@ -161,6 +160,11 @@
<artifactId>ignite-network-annotation-processor</artifactId>
<version>${project.version}</version>
</path>
+ <path>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a change in pull request #493: IGNITE-16067 Fix JMH benchmarks in the raft module
Posted by GitBox <gi...@apache.org>.
sashapolo commented on a change in pull request #493:
URL: https://github.com/apache/ignite-3/pull/493#discussion_r763778886
##########
File path: modules/raft/pom.xml
##########
@@ -161,6 +160,11 @@
<artifactId>ignite-network-annotation-processor</artifactId>
<version>${project.version}</version>
</path>
+ <path>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
Review comment:
Do you know how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #493: IGNITE-16067 Fix JMH benchmarks in the raft module
Posted by GitBox <gi...@apache.org>.
ibessonov merged pull request #493:
URL: https://github.com/apache/ignite-3/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a change in pull request #493: IGNITE-16067 Fix JMH benchmarks in the raft module
Posted by GitBox <gi...@apache.org>.
ibessonov commented on a change in pull request #493:
URL: https://github.com/apache/ignite-3/pull/493#discussion_r763723963
##########
File path: modules/raft/pom.xml
##########
@@ -161,6 +160,11 @@
<artifactId>ignite-network-annotation-processor</artifactId>
<version>${project.version}</version>
</path>
+ <path>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
Review comment:
Can we use this processor for test sources only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org