You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/13 10:57:42 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4290: remove class member from `where segment`
tristaZero opened a new pull request #4290: remove class member from `where segment`
URL: https://github.com/apache/incubator-shardingsphere/pull/4290
Fixes #4289.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4290:
remove class member from `where segment`
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4290: remove class member from `where segment`
URL: https://github.com/apache/incubator-shardingsphere/pull/4290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4290: remove class member from `where segment`
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4290: remove class member from `where segment`
URL: https://github.com/apache/incubator-shardingsphere/pull/4290#issuecomment-585690059
## Pull Request Test Coverage Report for [Build 9507](https://coveralls.io/builds/28708929)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.02%**) to **62.999%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28708929/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28708929) |
| :-- | --: |
| Change from base [Build 842](https://coveralls.io/builds/28707495): | 0.02% |
| Covered Lines: | 11006 |
| Relevant Lines: | 17470 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4290:
remove class member from `where segment`
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4290: remove class member from `where segment`
URL: https://github.com/apache/incubator-shardingsphere/pull/4290#issuecomment-585698194
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=h1) Report
> Merging [#4290](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f656abdf352379fa0b581fbca41a91ff5e564996?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4290 +/- ##
============================================
+ Coverage 59.16% 59.19% +0.02%
Complexity 352 352
============================================
Files 1018 1018
Lines 17478 17470 -8
Branches 3122 3121 -1
============================================
Hits 10341 10341
+ Misses 6482 6474 -8
Partials 655 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...parser/core/extractor/impl/dml/WhereExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9XaGVyZUV4dHJhY3Rvci5qYXZh) | `20% <ø> (+5.71%)` | `0 <0> (ø)` | :arrow_down: |
| [...phere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERNTFZpc2l0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=footer). Last update [f656abd...80cc5e2](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4290?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4290:
remove class member from `where segment`
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4290: remove class member from `where segment`
URL: https://github.com/apache/incubator-shardingsphere/pull/4290#issuecomment-585690059
## Pull Request Test Coverage Report for [Build 1712](https://coveralls.io/builds/28708709)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.03%**) to **63.005%**
---
| Totals | [](https://coveralls.io/builds/28708709) |
| :-- | --: |
| Change from base [Build 842](https://coveralls.io/builds/28707495): | 0.03% |
| Covered Lines: | 11007 |
| Relevant Lines: | 17470 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services