You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/05/15 11:16:17 UTC
[GitHub] [flink] FangYongs opened a new pull request, #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
FangYongs opened a new pull request, #22583:
URL: https://github.com/apache/flink/pull/22583
## What is the purpose of the change
Add e2e test for flink jdbc driver
## Brief change log
- Add FlinkDriverE2eTest
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1552681989
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1577940403
Hi @libenchao I have update this PR for e2e test, please help to review when you are free, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1567634131
Thanks @libenchao Sounds good to me, I'll move it there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1566533577
@FangYongs By saying "e2e test", I mean the tests in `flink-end-to-end-tests` module. What do you think about adding it there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on a diff in pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #22583:
URL: https://github.com/apache/flink/pull/22583#discussion_r1230706007
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java:
##########
@@ -168,7 +168,6 @@ public ShutdownThread(SqlGateway gateway) {
@Override
public void run() {
// Shutdown the gateway
- System.out.println("\nShutting down the Flink SqlGateway...");
Review Comment:
sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1566372389
Hi @libenchao Please have a look at this PR when you are free, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on a diff in pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #22583:
URL: https://github.com/apache/flink/pull/22583#discussion_r1230700575
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java:
##########
@@ -168,7 +168,6 @@ public ShutdownThread(SqlGateway gateway) {
@Override
public void run() {
// Shutdown the gateway
- System.out.println("\nShutting down the Flink SqlGateway...");
Review Comment:
@libenchao Yes, it will cause e2e test failed because the e2e test framework will check the `.out` log file and confirm that it is empty. I have confirmed this with @fsk119 that the `System.out.println` here is meaningless, we can remove them directly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1547671336
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "95bd05c8f6a9c147e6d46b50440d269930ccadc2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95bd05c8f6a9c147e6d46b50440d269930ccadc2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95bd05c8f6a9c147e6d46b50440d269930ccadc2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] FangYongs commented on pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #22583:
URL: https://github.com/apache/flink/pull/22583#issuecomment-1592175474
Hi @libenchao I have rebased master and updated this PR, please have a look again when you are free, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on a diff in pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #22583:
URL: https://github.com/apache/flink/pull/22583#discussion_r1230545042
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/SqlGateway.java:
##########
@@ -168,7 +168,6 @@ public ShutdownThread(SqlGateway gateway) {
@Override
public void run() {
// Shutdown the gateway
- System.out.println("\nShutting down the Flink SqlGateway...");
Review Comment:
Is this change expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao merged pull request #22583: [FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao merged PR #22583:
URL: https://github.com/apache/flink/pull/22583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org