You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:22:31 UTC

[GitHub] [systemds] Baunsgaard commented on a diff in pull request #1714: [SYSTEMDS-3254] Add new aliases for countDistinct built-in function

Baunsgaard commented on code in PR #1714:
URL: https://github.com/apache/systemds/pull/1714#discussion_r1009299535


##########
src/main/java/org/apache/sysds/parser/DMLTranslator.java:
##########
@@ -2065,12 +2065,14 @@ private Hop processParameterizedBuiltinFunctionExpression(ParameterizedBuiltinFu
 				break;
 
 			case COUNT_DISTINCT_ROW:
+			case UNIQUE_ROW:
 			case COUNT_DISTINCT_APPROX_ROW:
 				currBuiltinOp = new AggUnaryOp(target.getName(), DataType.MATRIX, target.getValueType(),
 						AggOp.valueOf(source.getOpCode().name()), Direction.Row, paramHops.get("data"));
 				break;
 
 			case COUNT_DISTINCT_COL:
+			case UNIQUE_COL:

Review Comment:
   Are these valid? is Unique also supporting approximate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org