You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/01 13:48:10 UTC
[GitHub] [airflow] alexandear opened a new pull request #19349: Fix typos in variable and comments
alexandear opened a new pull request #19349:
URL: https://github.com/apache/airflow/pull/19349
Fix typos in comments and unexported variables:
- propert - proper
- necssary - necessary
- deserialised - deserialized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r742249732
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
I think there is no need to standardi(s/z)e this tbh :D . Both should be accepted - we gain nothing by this standardization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741683636
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) on the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexandear commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
alexandear commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741693313
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
@kaxil I searched across the repository:
- `deserialis*` - 4 matches
- `deserializ*` - 100+ matches
It's better to choose one mostly used spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r742249732
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
I think there is no need to standardi(s/z)e this tbh :D . Both should be accepted - we gain nothing by this standardization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexandear commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
alexandear commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741693313
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
@kaxil I searched across the repository:
- `deserialis*` - 4 matches
- `deserializ*` - 100+ matches
It's better to choose one mostly used spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19349:
URL: https://github.com/apache/airflow/pull/19349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexandear commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
alexandear commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741693313
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
@kaxil I searched across the repository:
- `deserialis*` - 4 matches
- `deserializ*` - 100+ matches
It's better to choose one mostly used spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19349:
URL: https://github.com/apache/airflow/pull/19349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741683636
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) on the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r742249732
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
I think there is no need to standardi(s/z)e this tbh :D . Both should be accepted - we gain nothing by this standardization.
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
I think there is no need to standardi(s/z)e this tbh :D . Both should be accepted - we gain nothing by this standardization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836436
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836562
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19349: Fix typos in variable and comments
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-956248838
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741683636
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741683636
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) on the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836436
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741475927
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Both the spellings are correct: serialization (US spelling) or serialisation (UK spelling)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741683636
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
Should we standardise (or rather standardize :D) on the US spelling ? I think this is what we mostly have in our spelling_wordlist and docs :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexandear commented on a change in pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
alexandear commented on a change in pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#discussion_r741693313
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -523,7 +523,7 @@ def validate_deserialized_task(
if isinstance(task.params, ParamsDict):
assert serialized_task.params.dump() == task.params.dump()
- # Check that for Deserialised task, task.subdag is None for all other Operators
+ # Check that for Deserialized task, task.subdag is None for all other Operators
Review comment:
@kaxil I searched across the repository:
- `deserialis*` - 4 matches
- `deserializ*` - 100+ matches
It's better to choose one mostly used spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #19349:
URL: https://github.com/apache/airflow/pull/19349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19349: Fix typos in function parameter and comments
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19349:
URL: https://github.com/apache/airflow/pull/19349#issuecomment-959836562
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org