You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ebyhr (via GitHub)" <gi...@apache.org> on 2026/06/22 04:45:07 UTC
[I] CI silently passes when GitHub Actions job is expired [iceberg]
ebyhr opened a new issue, #16914:
URL: https://github.com/apache/iceberg/issues/16914
### Apache Iceberg version
None
### Query engine
None
### Please describe the bug 🐞
CI shows false green when the relevant GitHub Actions job is excluded from https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml
https://github.com/apache/iceberg-python has the same problem.
### Willingness to contribute
- [ ] I can contribute a fix for this bug independently
- [ ] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
- [ ] I cannot contribute a fix for this bug at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4772947905
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4772933960
Oh I see, you're right.
https://github.com/apache/iceberg/pull/16903/checks has a bunch of skipped CI (the black part of the progress bar). This is what `.github/workflows/asf-allowlist-check.yml` should prevent, so #16926 makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4769312655
I looked into this, i think its actually expected that dependabot PRs (like https://github.com/apache/iceberg/pull/16903/) do not modify the runtime-deps.txt file. And thus there can be a potential drift
This is somewhat documented at https://github.com/apache/iceberg/blob/fb6bb97e393b8af692973e3a1268cccf6ae2c5c2/runtime-deps.gradle#L33-L37
In https://github.com/apache/iceberg/pull/16233, I tried to get rid of the patch version runtime-deps.txt so that we see less noise.
All the changes in https://github.com/apache/iceberg/pull/16908/changes are for minor versions, which lines up with the above
I think maybe we just have to deal with this and manually update runtime-deps.txt. Open to suggestions! I'm just out of ideas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4772980254
tracking in https://github.com/apache/iceberg/issues/16934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4772501217
The stale runtime-deps.txt isn't the problem I want to address in this issue.
The problem I was seeing is CI shows false green when the action is removed from Apache approved_patterns.yml. I think CI should fail in the PR so we can avoid accidental merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #16914:
URL: https://github.com/apache/iceberg/issues/16914#issuecomment-4772964191
Unfortunately I copied this bug to every iceberg repo 😭
https://grep.app/search?f.path.pattern=github%2Fworkflows%2Fasf-allowlist-check.yml&f.repo.pattern=apache%2Ficeberg&q=paths%3A
- [x] apache/iceberg
- [ ] apache/iceberg-python
- [ ] apache/iceberg-rust
- [ ] apache/iceberg-go
- [ ] apache/iceberg-cpp
We should also copy over this CI check to https://github.com/apache/terraform-provider-iceberg/tree/main/.github for parity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #16914: CI doesn't run all jobs when GitHub Actions job is removed from Apache approved_patterns.yml
URL: https://github.com/apache/iceberg/issues/16914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org