You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/25 16:53:54 UTC

[GitHub] [camel] djencks commented on pull request #5127: Xref Alignment

djencks commented on pull request #5127:
URL: https://github.com/apache/camel/pull/5127#issuecomment-786047415


   I’d really appreciate it if everyone would remove this boilerplate before creating a PR.  If you fill it in that’s (possibly) one thing, but just leaving it in place effectively spams the list with a lot of useless verbiage.  An actual description of what the PR does would be really nice, but reproducing this nonsense is really annoying and time consuming to wade through.
   
   I think some projects might have found a way to have this kind of verbiage as a comment in the template, so the instructions are there when you’re creating the PR but then disappear once it is created.
   
   thanks
   David Jencks
   
   > On Feb 25, 2021, at 1:58 AM, Andrea Cosentino <no...@github.com> wrote:
   > 
   >  Make sure there is a JIRA issue <https://issues.apache.org/jira/browse/CAMEL> filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
   >  Each commit in the pull request should have a meaningful subject line and body.
   >  If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
   >  Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   >  Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   > Below are the contribution guidelines:
   > https://github.com/apache/camel/blob/master/CONTRIBUTING.md <https://github.com/apache/camel/blob/master/CONTRIBUTING.md>
   > <SNIP>
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org