You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/11 20:00:48 UTC
[GitHub] [geode] demery-pivotal opened a new pull request #7256: GEODE-9942: Include JUnit 5 tests in stress tests
demery-pivotal opened a new pull request #7256:
URL: https://github.com/apache/geode/pull/7256
PROBLEM
JUnit 5 test classes need not be public. Indeed, IntelliJ's default
inspections discourage making JUnit 5 classes public.
`StressTestHelper` uses a `ClassGraph` to gather information about test
classes. By default, the `ClassGraph` scans only public classes. So by
default, the `ClassGraph` does not gather information about JUnit 5
classes with non-public visibility.
As a result, our stress test scripts do not run JUnit 5 tests.
SOLUTION
Call `ignoreClassVisibility()` to configure the `ClassGraph` to scan all
classes, not just public ones.
A few poorly-controlled, unsophisticated experiments (on a 2016 MacBook)
show that this increases the scan duration from 3 seconds to 3.4
seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] demery-pivotal merged pull request #7256: GEODE-9942: Include JUnit 5 tests in stress tests
Posted by GitBox <gi...@apache.org>.
demery-pivotal merged pull request #7256:
URL: https://github.com/apache/geode/pull/7256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org