You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/28 06:42:18 UTC

[GitHub] [beam] reuvenlax commented on pull request #22347: [22188] Don't output from a timer for which noOutputTimestamp is set

reuvenlax commented on PR #22347:
URL: https://github.com/apache/beam/pull/22347#issuecomment-1197729766

   @johnjcasey per the above discussion, we now finalize idle streams inline in onTimer instead of using the FlushAndFinalizeDoFn. Long-term I would like to share this code as it's 98% the same, however the presence of Beam counters throughout makes it hard to share the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org