You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 20:59:13 UTC
[GitHub] [superset] codecov-io commented on pull request #13288: fix(sqllab): per-tab hide left bar
codecov-io commented on pull request #13288:
URL: https://github.com/apache/superset/pull/13288#issuecomment-783670520
# [Codecov](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=h1) Report
> Merging [#13288](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=desc) (79085a8) into [master](https://codecov.io/gh/apache/superset/commit/e8d50356a263617db584cc3c0effad1418bd34bc?el=desc) (e8d5035) will **increase** coverage by `10.43%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13288 +/- ##
===========================================
+ Coverage 69.48% 79.91% +10.43%
===========================================
Files 1050 298 -752
Lines 49755 24257 -25498
Branches 5322 0 -5322
===========================================
- Hits 34571 19386 -15185
+ Misses 15059 4871 -10188
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.91% <72.72%> (+12.54%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.36% <ø> (ø)` | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <ø> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.32% <0.00%> (-0.16%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.95% <100.00%> (-6.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `90.76% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <100.00%> (-5.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.01% <100.00%> (-3.88%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `91.21% <100.00%> (+0.05%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.80% <100.00%> (-3.58%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [760 more](https://codecov.io/gh/apache/superset/pull/13288/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=footer). Last update [a646914...79085a8](https://codecov.io/gh/apache/superset/pull/13288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org