[jira] [Commented] (AMBARI-17529) Ambari LogSearch REST Layer should not queue up requests that have already been made

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-17529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637331#comment-15637331 ] 

Hadoop QA commented on AMBARI-17529:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12837199/AMBARI-17529.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9146//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9146//console

This message is automatically generated.

> Ambari LogSearch REST Layer should not queue up requests that have already been made
> ------------------------------------------------------------------------------------
>
>                 Key: AMBARI-17529
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17529
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Robert Nettleton
>            Assignee: Robert Nettleton
>            Priority: Critical
>             Fix For: 2.5.0
>
>         Attachments: AMBARI-17529.patch.2
>
>
> The review for the fix for AMBARI-17510 brought up some interesting issues that should be investigated and addressed in a separate patch.
> From [~jonathan.hurley]'s comments on https://reviews.apache.org/r/49474/:
> "Based on what we've seen, the requests to the LOGSEARCH endpoint don't return until the connection times out (which could be never depending on what's configured). This will then cause this Executor to fill it's queue with a backlog of requests.
> Instead, maybe it would be better to:
> - Only enqueue if the request isn't already enqueued
> - Use a bounded executor and rejection policy"
> This work will involve investigating the best approach towards limiting the possibility of duplicate requests being made to the LogSearch REST service, either by making a check prior to adding the request, or by using a bounded executor in the way described above. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)