You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/14 19:47:35 UTC

Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54216/#review159219
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 30, 2016, 6:55 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54216/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 6:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-6504
>     https://issues.apache.org/jira/browse/MESOS-6504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should check the root privileges by using the effective user
> id, instead of comparing os::user() to 'root'.
> 
> 
> Diffs
> -----
> 
>   src/launcher/posix/executor.cpp da0081c0e470aebb16d2e78031d276f5d7d2c726 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 8f024d084189b59bb229c63d20108e7bfe42065f 
>   src/slave/containerizer/mesos/isolators/gpu/volume.cpp 478752f372200b79cb3bd1e1c0f254f529930b78 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp c92c6c7174421158b9190ed0bfb00c1c97ef0f7b 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 94dac40a12b6fd2e7d9733444d84763c77785402 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp b71a31323aef376c9a28e1d52322a1802fb212ad 
> 
> Diff: https://reviews.apache.org/r/54216/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>