[GitHub] [lucene] uschindler commented on a diff in pull request #12286: toposort use iterator to avoid stackoverflow

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on code in PR #12286:
URL: https://github.com/apache/lucene/pull/12286#discussion_r1192326625


##########
lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java:
##########
@@ -39,6 +39,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.Stack;

Review Comment:
   Use `Deque` interface with `ArrayDeque` as implementation instead, Stack is a relic (synchronized) from JDK 1.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org