You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/03/13 17:38:08 UTC

[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #271: Create memory table

andygrove commented on code in PR #271:
URL: https://github.com/apache/arrow-datafusion-python/pull/271#discussion_r1134383975


##########
src/sql/logical.rs:
##########
@@ -60,6 +61,7 @@ impl PyLogicalPlan {
             LogicalPlan::Analyze(plan) => PyAnalyze::from(plan.clone()).to_variant(py),
             LogicalPlan::EmptyRelation(plan) => PyEmptyRelation::from(plan.clone()).to_variant(py),
             LogicalPlan::Explain(plan) => PyExplain::from(plan.clone()).to_variant(py),
+            LogicalPlan::Extension(plan) => PyExtension::from(plan.clone()).to_variant(py),

Review Comment:
   Should there be a new entry here for `CreateMemoryTable` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org