You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/02/23 07:03:43 UTC
[GitHub] flink pull request #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint ...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5565
[FLINK-8459][flip6] Implement cancelWithSavepoint in RestClusterClient
## What is the purpose of the change
This pull request implements cancelWithSavepoint in RestClusterClient for flip6.
## Brief change log
- split the function into two steps: send REST call `triggerSavepoint` and send REST call `cancel`
## Verifying this change
This change added tests and can be verified as follows:
- Added a test to check savepoint path and job's termination state is canceled.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5565
----
commit a4b97d8f305bed09c154fb88ba8e06879532e1ed
Author: vinoyang <vi...@...>
Date: 2018-02-23T06:52:11Z
[FLINK-8459][flip6] Implement cancelWithSavepoint in RestClusterClient
----
---
[GitHub] flink issue #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint in Rest...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5565
Hi @tillrohrmann would you please review this PR, Thanks.
---
[GitHub] flink pull request #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint ...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5565
---
[GitHub] flink issue #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint in Rest...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5565
@GJL OK, That's all right. Now I close this PR.
---
[GitHub] flink issue #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint in Rest...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5565
@yanghua Thanks for your contribution but I am afraid to tell you that we have changed our mind and decided that it is better not to allow checkpoints between the savepoint and job cancelation.
#5622 already implements this.
cc: @tillrohrmann
---