You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:39:15 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #29267: [SPARK-32424][SQL][3.0] Fix silent data change for timestamp parsing if f overflow happens
yaooqinn commented on a change in pull request #29267:
URL: https://github.com/apache/spark/pull/29267#discussion_r461288263
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -146,7 +146,3 @@ select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampF
select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-
-select from_unixtime(1, 'yyyyyyyyyyy-MM-dd');
Review comment:
I checked these tests which are added to test cases that exceed 10-'y'. It's safe to remove because now it will fail starting from 7-'y' and we have already covered these in both datetime-parsing.sql and datetime-formatting.sql
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -146,7 +146,3 @@ select from_json('{"time":"26/October/2015"}', 'time Timestamp', map('timestampF
select from_json('{"date":"26/October/2015"}', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
select from_csv('26/October/2015', 'time Timestamp', map('timestampFormat', 'dd/MMMMM/yyyy'));
select from_csv('26/October/2015', 'date Date', map('dateFormat', 'dd/MMMMM/yyyy'));
-
-select from_unixtime(1, 'yyyyyyyyyyy-MM-dd');
Review comment:
I checked these tests which were added to test cases that exceed 10-'y'. It's safe to remove them now because they will fail starting from 7-'y' and we have already covered these in both datetime-parsing.sql and datetime-formatting.sql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org