You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/09/16 22:24:27 UTC

Change in asterixdb[master]: [ASTERIXDB-2956][IDX] Adding RQG for array indexes + fixes

From Glenn Galvizo <gg...@uci.edu>:

Hello Dmitry Lychagin, Jenkins, Anon. E. Moose #1000171, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13263

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2956][IDX] Adding RQG for array indexes + fixes
......................................................................

[ASTERIXDB-2956][IDX] Adding RQG for array indexes + fixes

- user model changes: no
- storage format changes: no
- interface changes: no

Adding RQGs for array indexes and the fixes detailed below:
- Handle conjuncts with nested ANDs (for SOME AND EVERY).
- Disable merge-select local rewrite when a join is encountered.
- Analyze for array indexes for each ASSIGN op (as opposed to the last
  ASSIGN).
- Disable INLJ with cross products in probe (ASTERIXDB-2966 bug).
- Enable general theta join INLJ acceleration with array indexes.
- Fix type builder bug for getting array type (at initial ingestion).
- Insert filter for unknowns for atomic fields (at initial ingestion).
- Small fixes to get composite-atomic index initial ingestion working
  (now evaluators and record descriptors between operators are correct).

Change-Id: I25a0f34010bca6296e75c6d6bc04eb515376941f
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/ArrayBTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/array/AbstractOperatorFromSubplanRewrite.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/array/JoinFromSubplanRewrite.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/array/MergedSelectRewrite.java
A asterixdb/asterix-app/data/array-index.adm
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ArrayDataset.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ArrayElement.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ArrayIndex.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ArrayQuery.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ArrayQueryUtil.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/BaseWisconsinTable.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/SqlppArrayIndexRQGTest.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/array/ValueSupplierFactory.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query8.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query9.plan
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryArrayIndexBTreeOperationsHelper.java
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/TypeUtil.java
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryUpsertWithNestedPlanOperatorNodePushable.java
20 files changed, 2,868 insertions(+), 63 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/63/13263/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13263
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I25a0f34010bca6296e75c6d6bc04eb515376941f
Gerrit-Change-Number: 13263
Gerrit-PatchSet: 7
Gerrit-Owner: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: newpatchset