You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/15 19:21:04 UTC

[jira] [Commented] (KAFKA-5249) Transaction index recovery does not snapshot properly

    [ https://issues.apache.org/jira/browse/KAFKA-5249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011162#comment-16011162 ] 

ASF GitHub Bot commented on KAFKA-5249:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/3060

    KAFKA-5249: Fix incorrect producer snapshot offsets when recovering segments

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-5249

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3060.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3060
    
----
commit 5018fcdca321c322850f8d7bddfbc503a7dda8a2
Author: Jason Gustafson <ja...@confluent.io>
Date:   2017-05-15T19:19:42Z

    KAFKA-5249: Fix incorrect producer snapshot offsets when recovering segments

----


> Transaction index recovery does not snapshot properly
> -----------------------------------------------------
>
>                 Key: KAFKA-5249
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5249
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>
> When recovering the transaction index, we should take snapshots of the producer state after recovering each segment. Currently, the snapshot offset is not updated correctly so we will reread the segment multiple times. Additionally, it appears that we do not remove snapshots with offsets higher than the log end offset in all cases upon truncation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)