You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/06/01 06:13:43 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31661: Improve the views module a bit

jedcunningham commented on code in PR #31661:
URL: https://github.com/apache/airflow/pull/31661#discussion_r1212627811


##########
airflow/www/views.py:
##########
@@ -3251,9 +3231,9 @@ def duration(self, dag_id: str, session: Session = NEW_SESSION):
         cum_chart.buildcontent()
         s_index = cum_chart.htmlcontent.rfind("});")
         cum_chart.htmlcontent = (
-            cum_chart.htmlcontent[:s_index]
-            + "$( document ).trigger('chartload')"
-            + cum_chart.htmlcontent[s_index:]
+            f"{cum_chart.htmlcontent[:s_index]}"
+            f"$( document ).trigger('chartload')"

Review Comment:
   ```suggestion
               "$( document ).trigger('chartload')"
   ```
   
   Doesn't need to be an fstring



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org