You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "lsy3993 (via GitHub)" <gi...@apache.org> on 2025/05/29 13:40:16 UTC
[PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
lsy3993 opened a new pull request, #51369:
URL: https://github.com/apache/doris/pull/51369
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #51328
Problem Summary:
SQL : `show partitions from table_name where PartitionId = 123 limit 100,1`
if the row number of 'show partitions from table_name where PartitionId = 123' is less than the offset value, the SQL may get an error.
So just return empty set when we encounter that situation. (The behaviors of old optimizer and nereids are the same.)
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2919508934
<details>
<summary>TPC-H: <b>Total hot run time: 33827 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ff10e3a57ee19da92370c1947739ac360591502d, data reload: false
------ Round 1 ----------------------------------
q1 26272 5108 5008 5008
q2 1956 274 182 182
q3 10366 1248 719 719
q4 10274 989 523 523
q5 8422 2434 2330 2330
q6 227 161 132 132
q7 914 735 608 608
q8 9296 1227 1126 1126
q9 6796 5110 5081 5081
q10 6856 2312 1898 1898
q11 497 287 267 267
q12 334 349 213 213
q13 17783 3667 3059 3059
q14 223 235 212 212
q15 560 470 488 470
q16 416 429 373 373
q17 585 858 356 356
q18 7729 7284 7157 7157
q19 1729 953 542 542
q20 328 332 219 219
q21 3609 2621 2395 2395
q22 1024 1020 957 957
Total cold run time: 116196 ms
Total hot run time: 33827 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5203 5095 5111 5095
q2 243 314 219 219
q3 2137 2666 2294 2294
q4 1302 1742 1357 1357
q5 4569 4393 4386 4386
q6 210 168 126 126
q7 1986 1889 1702 1702
q8 2591 2533 2561 2533
q9 7209 7163 7109 7109
q10 3000 3176 2716 2716
q11 562 511 503 503
q12 676 761 646 646
q13 3529 3853 3282 3282
q14 285 295 277 277
q15 530 490 474 474
q16 473 491 467 467
q17 1147 1474 1382 1382
q18 7830 7630 7400 7400
q19 803 760 843 760
q20 2040 2025 1863 1863
q21 4843 4304 4281 4281
q22 1069 1027 987 987
Total cold run time: 52237 ms
Total hot run time: 49859 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2919555998
<details>
<summary>ClickBench: <b>Total hot run time: 28.71 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ff10e3a57ee19da92370c1947739ac360591502d, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.11 0.10
query3 0.26 0.20 0.20
query4 1.59 0.20 0.18
query5 0.44 0.43 0.43
query6 1.16 0.65 0.66
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.57 0.52 0.50
query10 0.56 0.58 0.57
query11 0.15 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.61 0.60
query14 0.78 0.82 0.79
query15 0.86 0.84 0.84
query16 0.38 0.38 0.38
query17 1.01 1.03 1.05
query18 0.23 0.21 0.21
query19 1.95 1.86 1.84
query20 0.01 0.02 0.01
query21 15.40 0.91 0.56
query22 0.76 1.30 0.72
query23 14.75 1.39 0.65
query24 7.48 1.30 0.47
query25 0.51 0.18 0.09
query26 0.67 0.18 0.14
query27 0.06 0.05 0.06
query28 8.92 0.87 0.44
query29 12.53 4.01 3.25
query30 0.26 0.09 0.06
query31 2.80 0.60 0.38
query32 3.24 0.55 0.46
query33 2.98 3.07 3.02
query34 15.85 5.09 4.49
query35 4.48 4.50 4.50
query36 0.65 0.49 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.16 0.13 0.14
query41 0.07 0.02 0.02
query42 0.04 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 102.75 s
Total hot run time: 28.71 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2919440316
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2921111614
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "lsy3993 (via GitHub)" <gi...@apache.org>.
lsy3993 commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2919437980
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #51369:
URL: https://github.com/apache/doris/pull/51369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "lsy3993 (via GitHub)" <gi...@apache.org>.
lsy3993 commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2920892574
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2921111664
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](show)fix show partitions error when offset is bigger than partitions' number [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #51369:
URL: https://github.com/apache/doris/pull/51369#issuecomment-2919541119
<details>
<summary>TPC-DS: <b>Total hot run time: 185695 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ff10e3a57ee19da92370c1947739ac360591502d, data reload: false
query1 1010 481 491 481
query2 6560 1861 1815 1815
query3 6767 233 218 218
query4 26091 23920 23100 23100
query5 4377 624 464 464
query6 301 205 213 205
query7 4636 494 286 286
query8 260 222 220 220
query9 8604 2643 2648 2643
query10 489 333 259 259
query11 15876 14948 14748 14748
query12 155 108 105 105
query13 1662 534 416 416
query14 8825 6217 6068 6068
query15 214 200 167 167
query16 7136 621 489 489
query17 948 726 582 582
query18 1974 433 300 300
query19 187 192 171 171
query20 122 117 124 117
query21 208 121 104 104
query22 4203 4268 4137 4137
query23 34001 33095 33095 33095
query24 8477 2414 2412 2412
query25 551 456 397 397
query26 1250 275 153 153
query27 2745 506 344 344
query28 4363 2138 2135 2135
query29 797 541 432 432
query30 278 213 187 187
query31 952 862 772 772
query32 70 66 64 64
query33 560 366 338 338
query34 827 883 517 517
query35 785 823 725 725
query36 947 942 909 909
query37 110 98 85 85
query38 4135 4171 4031 4031
query39 1506 1405 1405 1405
query40 211 119 110 110
query41 65 57 60 57
query42 142 109 109 109
query43 493 505 470 470
query44 1345 832 841 832
query45 185 181 173 173
query46 837 1040 627 627
query47 1766 1820 1751 1751
query48 387 426 314 314
query49 741 490 400 400
query50 685 676 397 397
query51 4149 4198 4085 4085
query52 106 111 97 97
query53 230 255 190 190
query54 577 591 512 512
query55 86 85 88 85
query56 356 322 287 287
query57 1140 1151 1102 1102
query58 267 266 278 266
query59 2573 2664 2488 2488
query60 355 347 340 340
query61 156 153 148 148
query62 823 735 674 674
query63 227 200 191 191
query64 4498 1066 683 683
query65 4205 4137 4143 4137
query66 1157 420 309 309
query67 15881 15701 15325 15325
query68 9172 889 534 534
query69 471 319 326 319
query70 1241 1152 1100 1100
query71 458 326 297 297
query72 5666 4692 4657 4657
query73 703 598 355 355
query74 9040 8929 8914 8914
query75 4235 3232 2678 2678
query76 3638 1235 779 779
query77 954 388 368 368
query78 10082 10201 9377 9377
query79 2132 864 577 577
query80 782 513 445 445
query81 460 249 214 214
query82 420 125 98 98
query83 289 247 236 236
query84 296 109 93 93
query85 780 355 381 355
query86 334 300 273 273
query87 4480 4431 4269 4269
query88 3148 2272 2293 2272
query89 395 320 285 285
query90 1912 204 204 204
query91 149 144 118 118
query92 73 62 64 62
query93 1340 963 578 578
query94 676 424 309 309
query95 371 287 284 284
query96 495 569 288 288
query97 2731 2753 2631 2631
query98 236 202 201 201
query99 1428 1400 1270 1270
Total cold run time: 275189 ms
Total hot run time: 185695 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org