You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/05/11 05:41:16 UTC

[jira] [Commented] (TS-1889) refactor remap plugin request URL handling

    [ https://issues.apache.org/jira/browse/TS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655133#comment-13655133 ] 

ASF subversion and git services commented on TS-1889:
-----------------------------------------------------

Commit ed93dcbf7e394a1ff4b57365ea0148ef7c6db249 in branch refs/heads/master from [~jpeach@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ed93dcb ]

TS-1889: refactor remap plugin request URL handling

For (apparantly) historical reasons, the remap plugin support
duplicated the request URL rewriting code. There's really no need for
this, and it's actually harmful since we don't want the behavior
to diverge due to the presence of a remap plugin.

This change removes the dodgy request URL rewriting code and uses
the same rewriting code that is used in the non-plugin case. This
is easier to understand and more reliable.

                
> refactor remap plugin request URL handling
> ------------------------------------------
>
>                 Key: TS-1889
>                 URL: https://issues.apache.org/jira/browse/TS-1889
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins, Remap API
>            Reporter: James Peach
>
> Traffic Server always rewrites URLs when it proxies them. The rewrite can be controlled by a configuration file or by code in a loadable plugin. The default URL rewriting code was duplicated for these two cases. This change removes the code duplication from the plugin rewrite case and simplifies the call site. It does not result in any change of behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira