You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2015/06/01 19:49:38 UTC

Re: Review Request 33400: OOZIE-2215 Support glob in FS EL function

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33400/
-----------------------------------------------------------

(Updated June 1, 2015, 5:49 p.m.)


Review request for oozie.


Changes
-------

one weird thing in Pathfilter behavior is, 
fs.globStatus(path, new FSPathFilter());
when path is some non-existent single path (no glob expression),  PathFilter.accept() is called even though it does not exist. 
if thrwoing exception at first discovery, it breaks test case..  

this version is, not throwing excpetion at first discovery, but avoid duplicated check done in the orignal verison.  
also added glob max check, and to support normal datapipeline application, raised fs glob max to 50K.


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2215


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java f8af61c 
  core/src/main/resources/oozie-default.xml 8960073 
  core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java c81fc61 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 02dc65b 

Diff: https://reviews.apache.org/r/33400/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 33400: OOZIE-2215 Support glob in FS EL function

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33400/#review87085
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java
<https://reviews.apache.org/r/33400/#comment139363>

    exists variable not required
    
    return (pathArr != null && pathArr.length > 0);



docs/src/site/twiki/WorkflowFunctionalSpec.twiki
<https://reviews.apache.org/r/33400/#comment139362>

    ...when there is at least one ...


- Rohini Palaniswamy


On June 1, 2015, 5:49 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33400/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:49 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2215
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java f8af61c 
>   core/src/main/resources/oozie-default.xml 8960073 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java c81fc61 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki 02dc65b 
> 
> Diff: https://reviews.apache.org/r/33400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 33400: OOZIE-2215 Support glob in FS EL function

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33400/#review86855
-----------------------------------------------------------


this behavior is observed in hadoop-1 only,  fixed in hadoop-2

- Ryota Egashira


On June 1, 2015, 5:49 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33400/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:49 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2215
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java f8af61c 
>   core/src/main/resources/oozie-default.xml 8960073 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java c81fc61 
>   docs/src/site/twiki/WorkflowFunctionalSpec.twiki 02dc65b 
> 
> Diff: https://reviews.apache.org/r/33400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 33400: OOZIE-2215 Support glob in FS EL function

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33400/
-----------------------------------------------------------

(Updated June 8, 2015, 10:14 p.m.)


Review request for oozie.


Changes
-------

final one


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2215


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java f8af61c 
  core/src/main/resources/oozie-default.xml 8960073 
  core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java c81fc61 
  docs/src/site/twiki/WorkflowFunctionalSpec.twiki 02dc65b 

Diff: https://reviews.apache.org/r/33400/diff/


Testing
-------


Thanks,

Ryota Egashira