[jira] Commented: (JCR-2256) JSR 283 Repository Descriptors

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742791#action_12742791 ] 

angela commented on JCR-2256:
-----------------------------

steps to fix this:

jcr2spi-level
------------------------------------------------------------------------------------------------------------------------

- Repository.getDescriptorValue and Repository.getDescriptorValues isn't implemented
- Maybe it's best to have a new method on the RepoService that returns the descriptors
  in almost-jcr-value format and then having using the ValueFactoryQImpl created with
  a dummy-namespace-resolver to build the required value objects from the SPI
  value representation.
- the old getDescriptor() method should just be a shortcut to the new methods and
  return 'null' in case of multi-valued or Value.getString in case of single valued.

spi-level
------------------------------------------------------------------------------------------------------------------------

- the method Map<String, String> getRepositoryDescriptors() throws RepositoryException
  isn't sufficient to cover the new descriptor functionality defined by jsr 283

- I'd suggest to either change the return value of the existing method to Map<String, QValue[]>
  or deprecate the existing method an replace with a appropriate one, that properly
  covers the multivalued, non string descriptors (maybe better).

- jcr2spi should then only use the method returning QValue(s) see above.

spi2jcr
------------------------------------------------------------------------------------------------------------------------

- should be straight forward, once the SPI is adjusted.

spi2dav(ex)
------------------------------------------------------------------------------------------------------------------------

- jcr-server must be fixed in order to cover the new Repository methods.
  -> RepositoryDescriptorReport must use Repository.getDescriptorValues(String key)
  -> RepositoryDescriptorReport must deal with multi valued descriptors

once this is fixed:
- spi2dav RepositoryServiceImpl must properly handle multi and single values as well
  as non-string values and create QValue objects.





> JSR 283 Repository Descriptors
> ------------------------------
>
>                 Key: JCR-2256
>                 URL: https://issues.apache.org/jira/browse/JCR-2256
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-jcr-server, jackrabbit-jcr2spi, jackrabbit-spi, jackrabbit-spi2dav, jackrabbit-spi2jcr, JCR 2.0
>            Reporter: angela
>
> - new methods returning Value objects (jcr2spi)
> - check descriptor-report in jcr-server and corresponding handling on the client side
> - etc.etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.