You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2023/02/28 02:58:07 UTC
[GitHub] [cordova-common] erisu opened a new pull request, #199: dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt
erisu opened a new pull request, #199:
URL: https://github.com/apache/cordova-common/pull/199
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
n/a
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
use latest npm glob dependency.
### Description
<!-- Describe your changes in detail -->
- bump glob to 9.0.1
- updated code to use `glob.globSync`, not `glob.sync`.
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #199: dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #199:
URL: https://github.com/apache/cordova-common/pull/199#issuecomment-1447553615
Unable to reproduce the failing tests on my Windows 10 Pro environment.
I changed the status of this PR to draft and set its milestone for 6.0.0. More investigation is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #199: dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #199:
URL: https://github.com/apache/cordova-common/pull/199#issuecomment-1447522278
# [Codecov](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#199](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2f25fa) into [master](https://codecov.io/gh/apache/cordova-common/commit/ecad4db41f7397216cd3d83bd77a4f8a89f720a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecad4db) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 20 20
Lines 1144 1144
=======================================
Hits 1011 1011
Misses 133 133
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/ConfigChanges/ConfigFile.js](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL0NvbmZpZ0NoYW5nZXMvQ29uZmlnRmlsZS5qcw==) | `92.23% <100.00%> (ø)` | |
| [src/PluginInfo/PluginInfoProvider.js](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL1BsdWdpbkluZm8vUGx1Z2luSW5mb1Byb3ZpZGVyLmpz) | `79.31% <100.00%> (ø)` | |
| [src/superspawn.js](https://codecov.io/gh/apache/cordova-common/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3N1cGVyc3Bhd24uanM=) | `85.24% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] [RFC] dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt [cordova-common]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue closed pull request #199: [RFC] dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt
URL: https://github.com/apache/cordova-common/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org