[GitHub] jonpspri opened a new pull request #4192: Adjustments to support multi-arch builds of OpenWhisk.

[GitBox <gi...@apache.org>]

jonpspri opened a new pull request #4192: Adjustments to support multi-arch builds of OpenWhisk.
URL: https://github.com/apache/incubator-openwhisk/pull/4192
 
 
   Changes to OpenWhisk to support Multi-Architecture builds:
   
   1.  Support of 'docker --build-args FOO=BAR' in gradle/docker.gradle
       has been broken for who knows how long, but with modern docker
       now support ARG before the FROM line, it's necessary that it work
       for build customizition and configuration.
   2.  The AdoptOpenJDK project is working on multi-architecture alpine
       builds, but they're not yet available on Docker Hub, so use that
       ARG line to get them from the S390X builds.  Also bump the JDK
       version (I could live with making that an argument).
   3.  Add some stuff to the 'tools/ow-util/Dockerfile' to support
       architecture-aware downloads rather than naively downloading
       everything for x86_64.
   
   I _think_ because of what I see in other programs, that OpenWhisk
   is now using a more modern Docker to build images, but I'll let
   Travis be the judge of that.
   
   
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes are tested. -->
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services