[jira] [Commented] (ISIS-845) Hidden (Where.REFERENCES_PARENT) should take into account the instance that is the parent, not just its type.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650430#comment-15650430 ] 

ASF subversion and git services commented on ISIS-845:
------------------------------------------------------

Commit 710e17705a1dc176ad47c5b7e83cb6681b204a66 in isis's branch refs/heads/ISIS-845 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=710e177 ]

ISIS-845: (wip) checks all instances of elements to see whether reference parent


> Hidden (Where.REFERENCES_PARENT) should take into account the instance that is the parent, not just its type.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-845
>                 URL: https://issues.apache.org/jira/browse/ISIS-845
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: core-1.6.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 1.14.0
>
>
> For example:
> PartyRelationship {
>     fromParty;
>     toParty;
> }
> if rendered from the point of view of the from party, would want to show only the toParty.  But adding this annotation causes both properties to be suppressed.
> This can be seen in the code:
> {code}
>     static Filter<ObjectAssociation> associationDoesNotReferenceParent(final ObjectSpecification parentSpec) {
>         if(parentSpec == null) {
>             return Filters.any();
>         }
>         return new Filter<ObjectAssociation>() {
>             @Override
>             public boolean accept(ObjectAssociation association) {
>                 final HiddenFacet facet = association.getFacet(HiddenFacet.class);
>                 if(facet == null) {
>                     return true;
>                 }
>                 if (facet.where() != Where.REFERENCES_PARENT) {
>                     return true;
>                 }
>                 final ObjectSpecification assocSpec = association.getSpecification();
>                 final boolean associationSpecIsOfParentSpec = parentSpec.isOfType(assocSpec);
>                 final boolean isVisible = !associationSpecIsOfParentSpec;
>                 return isVisible;
>             }
>         };
>     }
> {code}
> Instead, the code should take into account the actual instance that is referenced, not just the type (ie look at the object that the association points back to).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)