You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/22 16:14:18 UTC

[GitHub] ashb commented on a change in pull request #4560: [AIRFLOW-3733] Init variable i avoid raise NameError

ashb commented on a change in pull request #4560: [AIRFLOW-3733] Init variable i avoid raise NameError
URL: https://github.com/apache/airflow/pull/4560#discussion_r249851327
 
 

 ##########
 File path: airflow/hooks/hive_hooks.py
 ##########
 @@ -878,6 +878,7 @@ def to_csv(
         header = next(results_iter)
         message = None
 
+        i = 0
 
 Review comment:
   Yeah doming something like that is a bit odd.
   
   One question though: does this change work on Python3? I have half-memories of the scoping rules for `for` being different in py2 and py3, but I can't remember how.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services