[jira] [Updated] (CASSANDRA-4980) StorageServiceClientTest/RecoveryManager2Test fail on 1.2.0 and above branch

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-4980:
----------------------------------------

    Attachment: 0002-Clean-up-the-commit-log-before-RecoveryManager2Test.txt
                0001-fix-StorageServiceClientTest.txt

I'd rather avoid that if possible.

The problem in StorageServiceClientTest is imo a bug that this commit just happens to reveal. Namely, that for some reason {{SS.initClient()}} calls updateVersionAndAnnounce. But since fat clients are supposed to not have local tables, they will in particular have no schema and this is useless. If for some weird reason we really need fat client to send a 'I have no schema' on gossip, let's call {{MigrationManager.passiveAnnounce(Schema.emptyVersion)}} directly (but I don't see why we would need that).

As for RecoveryManager2Test, it's just that this test was somehow assuming the commit log was empty when the test started. Which was the case because we almost always flush when we write the system table, but it happens that for writing the schemaVersion in the local table I figured flushing was overkill (since it's only for client sake and we don't need to flush to have it visible).

Attaching simple fixes for both problems.
                
> StorageServiceClientTest/RecoveryManager2Test fail on 1.2.0 and above branch
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4980
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4980
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0 beta 2
>            Reporter: Yuki Morishita
>         Attachments: 0001-fix-StorageServiceClientTest.txt, 0002-Clean-up-the-commit-log-before-RecoveryManager2Test.txt
>
>
> Looks like change in c4cca2d8bba20a7651b956e1893727391bf5f10a (store schema_version to system.local) broke both StorageServiceClientTest and RecoveryManager2Test.
> StorageServiceClientTest assert data directories are not created in client mode but this change actually creates data directories. RecoveryManager2Test fails with "junit.framework.AssertionFailedError: Expecting only 1 replayed mutation, got 10" error and I think extra commit log also comes from this insert to system.local.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira