You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/04/21 10:07:32 UTC

[GitHub] [libcloud] antoinebourayne opened a new pull request #1448: storage account default value in azure_arm

antoinebourayne opened a new pull request #1448:
URL: https://github.com/apache/libcloud/pull/1448


   #1068  Default Value of create_node in azure_arm
   
   ### Description
   
   The parameter "ex_storage_account" must be provided even if the "ex_use_managed_disks" is set as True. Therefore this will lead to an error even if no storage account is needed if "ex_use_managed_disks" is set as True.
   
   ### Status
   
   Replace this: describe the PR status. Examples:
   
   - done, ready for review
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] asfgit merged pull request #1448: storage account default value in azure_arm

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1448:
URL: https://github.com/apache/libcloud/pull/1448


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1448: storage account default value in azure_arm

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1448:
URL: https://github.com/apache/libcloud/pull/1448#issuecomment-640117665


   I've simplified the code a bit (08bf4762203b946e03731d158c3b2df17d07b6d1), added a test case (5f0d9f6f2636e138e90a1c86388f0952825133df) and merged it into trunk.
   
   Thanks for the contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1448: storage account default value in azure_arm

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1448:
URL: https://github.com/apache/libcloud/pull/1448#issuecomment-636208486


   @antoinebourayne Can you please add a corresponding test case so we can merge this?
   
   Besides that, LGTM :+1: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org