You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/04 15:11:45 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #1008: Remove out of date comment
alamb opened a new pull request #1008:
URL: https://github.com/apache/arrow-rs/pull/1008
re #996
@jhorstmann points out that `bool` no longer implements `ArrowNativeType` and thus this comment it out of date. Remove it
```
/Users/alamb/Software/arrow-rs/arrow/src/datatypes/native.rs
118: impl ArrowNativeType for i8 {
141: impl ArrowNativeType for i16 {
164: impl ArrowNativeType for i32 {
193: impl ArrowNativeType for i64 {
222: impl ArrowNativeType for u8 {
245: impl ArrowNativeType for u16 {
268: impl ArrowNativeType for u32 {
291: impl ArrowNativeType for u64 {
326: impl ArrowNativeType for f16 {}
327: impl ArrowNativeType for f32 {}
328: impl ArrowNativeType for f64 {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1008: Remove out of date comment
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1008:
URL: https://github.com/apache/arrow-rs/pull/1008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1008: Remove out of date comment
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1008:
URL: https://github.com/apache/arrow-rs/pull/1008#issuecomment-986045509
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1008](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e6cabd) into [master](https://codecov.io/gh/apache/arrow-rs/commit/5806d29794cee97a4d0d06969627a83d59bea467?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5806d29) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1008 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 49031 49031
=======================================
Hits 40360 40360
Misses 8671 8671
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/buffer/immutable.rs](https://codecov.io/gh/apache/arrow-rs/pull/1008/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9pbW11dGFibGUucnM=) | `97.84% <ø> (ø)` | |
| [arrow/src/datatypes/field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1008/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9maWVsZC5ycw==) | `53.37% <0.00%> (-0.31%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1008/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5806d29...9e6cabd](https://codecov.io/gh/apache/arrow-rs/pull/1008?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org