You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/25 00:01:11 UTC

Review Request 61908: Used path::absolute to replace some startsWith checks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61908/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-7306
    https://issues.apache.org/jira/browse/MESOS-7306


Repository: mesos


Description
-------

Used path::absolute to replace some startsWith checks.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp d7fe9a8f43ab6436fc1e202443e71cf6b7e2d0d3 


Diff: https://reviews.apache.org/r/61908/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Re: Review Request 61908: Used path::absolute to replace some startsWith checks.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61908/#review183995
-----------------------------------------------------------


Ship it!




Oh, didn't notice this one when I commented on an earlier patch.
I'd be OK with keeping this separate.  Squashing would be fine too.

- Joseph Wu


On Aug. 24, 2017, 5:01 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61908/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 5:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used path::absolute to replace some startsWith checks.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp d7fe9a8f43ab6436fc1e202443e71cf6b7e2d0d3 
> 
> 
> Diff: https://reviews.apache.org/r/61908/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>