You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/29 07:09:56 UTC
[GitHub] [apisix] 96RadhikaJadhav opened a new pull request #2890: Corrected the link
96RadhikaJadhav opened a new pull request #2890:
URL: https://github.com/apache/apisix/pull/2890
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? --> It will direct the existing link to the correct one.
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735389299
> > > @Firstsawyou Facing issue while adding a semantic PR title..Need to know the process in detail..As this commit is already pushed, not getting from where to start. It will be great if you could help me with some steps :) ..Here is my mail id- [radhikajadhav014@gmail.com](mailto:radhikajadhav014@gmail.com)
> >
> >
> > You can click the `Edit` button to the right of the "PR" title to change the `PR` title. Add `docs:` before your title `Corrected the link`, like this: `dosc: Corrected the link`
>
> Its done, thanks @Firstsawyou
> But how to start the checks again so that sematic PR check will pass the test?
It still looks like it failed the semantic test. Try to modify it like this: `docs(architecture-design): corrected the link`. The C letter becomes lowercase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis closed pull request #2890: docs(architecture-design): corrected the link
Posted by GitBox <gi...@apache.org>.
membphis closed pull request #2890:
URL: https://github.com/apache/apisix/pull/2890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 96RadhikaJadhav commented on pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
96RadhikaJadhav commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735384098
> > @Firstsawyou Facing issue while adding a semantic PR title..Need to know the process in detail..As this commit is already pushed, not getting from where to start. It will be great if you could help me with some steps :) ..Here is my mail id- [radhikajadhav014@gmail.com](mailto:radhikajadhav014@gmail.com)
>
> You can click the `Edit` button to the right of the "PR" title to change the `PR` title. Add `docs:` before your title `Corrected the link`, like this: `dosc: Corrected the link`
Its done, thanks @Firstsawyou
But how to start the checks again so that sematic PR check will pass the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2890: docs(architecture-design): corrected the link
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735715678
new PR: https://github.com/apache/apisix/pull/2896
close this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou edited a comment on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735363125
You need to add a semantic `PR` title. Like this: `docs(architecture-design):Corrected the link`
How to add a semantic `PR` title, you can learn more about it here：[https://github.com/zeke/semantic-pull-requests](https://github.com/zeke/semantic-pull-requests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735383488
> @Firstsawyou Facing issue while adding a semantic PR title..Need to know the process in detail..As this commit is already pushed, not getting from where to start. It will be great if you could help me with some steps :) ..Here is my mail id- [radhikajadhav014@gmail.com](mailto:radhikajadhav014@gmail.com)
You can click the `Edit` button to the right of the "PR" title to change the `PR` title. Add `docs:` before your title `Corrected the link`, like this: `dosc: Corrected the link`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 96RadhikaJadhav commented on pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
96RadhikaJadhav commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735374970
@Firstsawyou Facing issue while adding a semantic PR title..Need to know the process in detail..As this commit is already pushed, not getting from where to start. It will be great if you could help me with some steps :) ..Here is my mail id- radhikajadhav014@gmail.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532209314
##########
File path: doc/architecture-design.md
##########
@@ -29,7 +29,7 @@
- [**Script**](#script)
- [**Upstream**](#upstream)
- [**Router**](#router)
-- [**Consumer**](#consumer)
+- [**Consumer**](#consumer1)
Review comment:
If you change this to `- [**Consumer**](#consumer-1)`, it will be correctly linked to the line `497` (https://github.com/apache/apisix/blame/master/doc/architecture-design.md#L497)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532182760
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
why add 1？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532205638
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
> > > @Firstsawyou Facing issue while adding a semantic PR title..Need to know the process in detail..As this commit is already pushed, not getting from where to start. It will be great if you could help me with some steps :) ..Here is my mail id- [radhikajadhav014@gmail.com](mailto:radhikajadhav014@gmail.com)
> >
> >
> > You can click the `Edit` button to the right of the "PR" title to change the `PR` title. Add `docs:` before your title `Corrected the link`, like this: `dosc: Corrected the link`
>
> Its done, thanks @Firstsawyou
> But how to start the checks again so that sematic PR check will pass the test?
It still looks like it failed the semantic test. Try to modify it like this: `docs(architecture-design): corrected the link`. The C letter becomes lowercase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#issuecomment-735363125
You need to add a semantic `PR` title. Like this: `docs(architecture-design):Corrected the link`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #2890: docs(architecture-design): corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532301201
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
> @Firstsawyou I'm getting error while pushing new changes now -->
> ! [rejected] Corrected-The-Link -> Corrected-The-Link (non-fast-forward)
> error: failed to push some refs to 'https://github.com/96RadhikaJadhav/apisix.git'
> hint: Updates were rejected because the tip of your current branch is behind
> hint: its remote counterpart. Integrate the remote changes (e.g.
> hint: 'git pull ...') before pushing again.
> hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Before you `git push`, you may need to do `git pull`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 96RadhikaJadhav commented on a change in pull request #2890: Corrected the link
Posted by GitBox <gi...@apache.org>.
96RadhikaJadhav commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532188035
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
@moonming - If you check here- https://github.com/apache/apisix/blob/master/doc/architecture-design.md#table-of-contents , the correct link for Consumer is showing as https://github.com/apache/apisix/blob/master/doc/architecture-design.md#consumer-1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532208535
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
@96RadhikaJadhav
I tried this link and the cause of this problem is the title of `Consumer` on line `382` (https://github.com/apache/apisix/blame/master/doc/architecture-design.md#L382) and ` The `Consumer` on line 497` is duplicated (https://github.com/apache/apisix/blame/master/doc/architecture-design.md#L497).
There is no need to add 1 here. We only need to modify the content of line `23` to `- [**Consumer**](#consumer-1)` .
We also need to update the Chinese documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 96RadhikaJadhav commented on a change in pull request #2890: docs(architecture-design): corrected the link
Posted by GitBox <gi...@apache.org>.
96RadhikaJadhav commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532339207
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
I tried but it's not working :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] 96RadhikaJadhav commented on a change in pull request #2890: docs(architecture-design):Corrected the link
Posted by GitBox <gi...@apache.org>.
96RadhikaJadhav commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532222375
##########
File path: doc/architecture-design.md
##########
@@ -494,7 +494,7 @@ Set the route that best suits your business needs in the local configuration `co
[Back to top](#Table-of-contents)
-## Consumer
+## Consumer1
Review comment:
@Firstsawyou I'm getting error while pushing new changes now -->
! [rejected] Corrected-The-Link -> Corrected-The-Link (non-fast-forward)
error: failed to push some refs to 'https://github.com/96RadhikaJadhav/apisix.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2890: docs(architecture-design): corrected the link
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2890:
URL: https://github.com/apache/apisix/pull/2890#discussion_r532378209
##########
File path: doc/architecture-design.md
##########
@@ -29,7 +29,7 @@
- [**Script**](#script)
- [**Upstream**](#upstream)
- [**Router**](#router)
-- [**Consumer**](#consumer)
+- [**Consumer**](#consumer1)
Review comment:
only update here should be enough @96RadhikaJadhav
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org