You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/18 02:17:37 UTC

[GitHub] [spark] zhengruifeng commented on issue #26154: [SPARK-29232][ML] Update the parameter maps of the DecisionTreeRegression/Classification Models

zhengruifeng commented on issue #26154: [SPARK-29232][ML] Update the parameter maps of the DecisionTreeRegression/Classification Models
URL: https://github.com/apache/spark/pull/26154#issuecomment-543454142
 
 
   One more question:
   [copyValues](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/param/params.scala#L884) suppose that 
   `   * Warning: This implicitly assumes that this [[Params]] instance and the target instance
      *          share the same set of default Params.`
   
   Is this satisfied?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org