You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Matthias Eckermann <mg...@suse.de> on 2000/01/06 17:56:27 UTC
[PATCH] mod_autoindex - new feature: UseTable
Hi,
the attached patch adds the option "UseTable" to mod_autoindex.
The patch is against the latest CVS (as of 20000106) of 1.3.10-dev.
I changed "mod_autoindex.c" and "mod_autoindex.html".
Hope, it's helpful.
Best regards
Matthias Eckermann
--
Matthias Eckermann <mg...@suse.de>
SuSE Muenchen GmbH Stahlgruberring 28 D-81829 Muenchen | errare
phone +49-89-427690 fax +49-89-42017701 mobile +49-179-2949448 | humanum
http://www.suse.de/ http://www.suse.com/ | est
Re: [PATCH] mod_autoindex - new feature: UseTable
Posted by Matthias Eckermann <mg...@suse.de>.
On Sat, Jan 08, 2000 at 12:21:26AM +0100 Matthias Eckermann (mge@suse.de) wrote:
>
> Yes, good option, patch is included (mod_autoindex-1.3.css).
Ooops, sorry, this patch is not complete.
> Mh, and there is another patch, without stylesheets at
> all:-(mod_autoindex-1.3.nocss)
>
> Patch "mod_autoindex-1.3.doc" contains the changes to mod_autoindex.html.
These are o.k., new patch "mod_autoindex-1.3.css"
will follow on monday, if necessary, ...
bye
Matthias
--
Matthias Eckermann <mg...@suse.de>
SuSE Muenchen GmbH Stahlgruberring 28 D-81829 Muenchen | errare
phone +49-89-427690 fax +49-89-42017701 mobile +49-179-2949448 | humanum
http://www.suse.de/ http://www.suse.com/ | est
Re: [PATCH] mod_autoindex - new feature: UseTable
Posted by Matthias Eckermann <mg...@suse.de>.
On Thu, Jan 06, 2000 at 02:08:54PM -0500 David Harris (dharris@drh.net) wrote:
>
> I think there are some problems with how the table created by this patch is
> defined by a stylesheet.
[...]
Hi,
thanks for your hints.
> (a) If the SuppressHTMLPreamble option is true, then you loose the formatting
> on the table because the stylesheet is never printed.
This is, what I intended: if the Author of "HEADER.html" wants
another layout of tables, he/she should get THEIR layout, not mine!
> (b) If the SuppressHTMLPreamble option is false, then you screw with the look
> of the HEADER.html file because you have re-defined the look of some common
> HTML elements. (The <style>..</style> section from emit_preamble will be
> printed before the HEADER.html file.)
>
> Problem B can be solved by using classes and not touching the definitions of
> the standard HTML tags. For example, change "table" to "table.autoindex" i
> in the stylesheet and use a class=autoindex in the appropriate table tag.
> I'm not sure how problem A could be solved.
Yes, good option, patch is included (mod_autoindex-1.3.css).
Mh, and there is another patch, without stylesheets at
all:-(mod_autoindex-1.3.nocss)
Patch "mod_autoindex-1.3.doc" contains the changes to mod_autoindex.html.
You may decide, what to use, ...
Best regards
Matthias Eckermann
--
Matthias Eckermann <mg...@suse.de>
SuSE Muenchen GmbH Stahlgruberring 28 D-81829 Muenchen | errare
phone +49-89-427690 fax +49-89-42017701 mobile +49-179-2949448 | humanum
http://www.suse.de/ http://www.suse.com/ | est
RE: [PATCH] mod_autoindex - new feature: UseTable
Posted by David Harris <dh...@drh.net>.
Matthias Eckermann wrote:
> << File: mod_autoindex-1.3.dif3 >> Hi,
>
> the attached patch adds the option "UseTable" to mod_autoindex.
> The patch is against the latest CVS (as of 20000106) of 1.3.10-dev.
>
> I changed "mod_autoindex.c" and "mod_autoindex.html".
>
> Hope, it's helpful.
>
> Best regards
> Matthias Eckermann
I think there are some problems with how the table created by this patch is
defined by a stylesheet.
This patch makes the emit_preamble code print out a <style>..</style> section
which re-defines styles for the "table", "td", and "a" HTML elements. There are
two problems with this when you consider a HEADER.html file being included.
(a) If the SuppressHTMLPreamble option is true, then you loose the formatting
on the table because the stylesheet is never printed.
(b) If the SuppressHTMLPreamble option is false, then you screw with the look
of the HEADER.html file because you have re-defined the look of some common
HTML elements. (The <style>..</style> section from emit_preamble will be
printed before the HEADER.html file.)
Problem B can be solved by using classes and not touching the definitions of
the standard HTML tags. For example, change "table" to "table.autoindex" in the
stylesheet and use a class=autoindex in the appropriate table tag. I'm not sure
how problem A could be solved.
Here is an example of a real-life HEADER.html setup that could get destroyed by
problem B:
http://www.engelschall.com/sw/str/
http://www.engelschall.com/sw/str/HEADER.html
- David Harris
Principal Engineer, DRH Internet Services