You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/03/17 21:25:15 UTC
[commons-compress] branch master updated: org.apache.commons.compress.archivers.zip.ZipFile.finalize() should not write to the std err
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new 05d24bd7 org.apache.commons.compress.archivers.zip.ZipFile.finalize() should not write to the std err
05d24bd7 is described below
commit 05d24bd73577cdc754067bdcbb5e77118dad7784
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Mar 17 17:25:09 2023 -0400
org.apache.commons.compress.archivers.zip.ZipFile.finalize() should not
write to the std err
---
src/changes/changes.xml | 5 +++--
src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 66b3d9e0..0d704ea0 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -62,8 +62,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Jonathan Leitschuh, Gary Gregory">Port some code from IO to NIO APIs.</action>
<action type="fix" dev="ggregory" due-to="Una, Gary Gregory, Jochen Wiedmann, quaternary, Bruno P. Kinoshita">pack200: Fix FileBands misusing InputStream#read(byte[]) #360.</action>
<action type="fix" issue="COMPRESS-641" dev="ggregory" due-to="XenoAmess, Gary Gregory, Bruno P. Kinoshita">Add TarArchiveEntry.getLinkFlag() #365.</action>
- <action type="fix" issue="COMPRESS-642" dev="ggregory" due-to="Anton Klarén, Gary Gregory">Integer overflow ArithmeticException in TarArchiveOutputStream #368.</action>
- <!-- ADD -->
+ <action type="fix" issue="COMPRESS-642" dev="ggregory" due-to="Anton Klarén, Gary Gregory">Integer overflow ArithmeticException in TarArchiveOutputStream #368.</action>
+ <action type="fix" issue="COMPRESS-642" dev="ggregory" due-to="Anton Klarén, Gary Gregory">org.apache.commons.compress.archivers.zip.ZipFile.finalize() should not write to the std err.</action>
+ <!-- ADD -->
<action type="add" issue="COMPRESS-614" dev="ggregory" due-to="Andre Brait, Gary Gregory">Use FileTime for time fields in SevenZipArchiveEntry #256.</action>
<action type="add" issue="COMPRESS-621" dev="ggregory" due-to="Glavo">Fix calculation the offset of the first ZIP central directory entry #334.</action>
<action type="add" issue="COMPRESS-633" dev="ggregory" due-to="Daniel Santos, Bruno P. Kinoshita, Gary Gregory">Add encryption support for SevenZ #332.</action>
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
index 641afca0..3ff26972 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
@@ -810,8 +810,6 @@ public class ZipFile implements Closeable {
protected void finalize() throws Throwable {
try {
if (!closed) {
- System.err.println("Cleaning up unclosed ZipFile for archive "
- + archiveName);
close();
}
} finally {