You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/13 09:42:00 UTC
[jira] [Work logged] (HIVE-26298) Selecting complex types on migrated iceberg table does not work
[ https://issues.apache.org/jira/browse/HIVE-26298?focusedWorklogId=780766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780766 ]
ASF GitHub Bot logged work on HIVE-26298:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/22 09:41
Start Date: 13/Jun/22 09:41
Worklog Time Spent: 10m
Work Description: lcspinter opened a new pull request, #3361:
URL: https://github.com/apache/hive/pull/3361
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Change iceberg field ID generation while converting hive schema to iceberg schema.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
When converting hive schema to iceberg schema the field ID is generated as we traverse the schema tree in preorder. This can be an issue while converting multiple levels of complex types since iceberg expects that the IDs are generated using a custom tree traversal technique.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Unit test
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Issue Time Tracking
-------------------
Worklog Id: (was: 780766)
Remaining Estimate: 0h
Time Spent: 10m
> Selecting complex types on migrated iceberg table does not work
> ---------------------------------------------------------------
>
> Key: HIVE-26298
> URL: https://issues.apache.org/jira/browse/HIVE-26298
> Project: Hive
> Issue Type: Bug
> Reporter: Gergely Fürnstáhl
> Assignee: László Pintér
> Priority: Major
> Attachments: 00001-a5d522f4-a065-44e6-983b-ba66596b4332.metadata.json
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I am working on implementing NameMapping in Impala (mainly replicating Hive's functionality) and ran into the following issue:
> {code:java}
> CREATE TABLE array_demo
> (
> int_primitive INT,
> int_array ARRAY<INT>,
> int_array_array ARRAY<ARRAY<INT>>,
> int_to_array_array_Map MAP<INT,ARRAY<ARRAY<INT>>>
> )
> STORED AS ORC;
> INSERT INTO array_demo values (0, array(1), array(array(2), array(3,4)), map(5,array(array(6),array(7,8))));
> select * from array_demo;
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> | array_demo.int_primitive | array_demo.int_array | array_demo.int_array_array | array_demo.int_to_array_array_map |
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> | 0 | [1] | [[2],[3,4]] | {5:[[6],[7,8]]} |
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> {code}
> Converting to iceberg
>
>
> {code:java}
> ALTER TABLE array_demo SET TBLPROPERTIES ('storage_handler'='org.apache.iceberg.mr.hive.HiveIcebergStorageHandler')
> select * from array_demo;
> INFO : Compiling command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe): select * from array_demo
> INFO : No Stats for default@array_demo, Columns: int_primitive, int_array, int_to_array_array_map, int_array_array
> INFO : Semantic Analysis Completed (retrial = false)
> INFO : Created Hive schema: Schema(fieldSchemas:[FieldSchema(name:array_demo.int_primitive, type:int, comment:null), FieldSchema(name:array_demo.int_array, type:array<int>, comment:null), FieldSchema(name:array_demo.int_array_array, type:array<array<int>>, comment:null), FieldSchema(name:array_demo.int_to_array_array_map, type:map<int,array<array<int>>>, comment:null)], properties:null)
> INFO : Completed compiling command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe); Time taken: 0.036 seconds
> INFO : Executing command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe): select * from array_demo
> INFO : Completed executing command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe); Time taken: 0.0 seconds
> INFO : OK
> Error: java.io.IOException: java.lang.IllegalArgumentException: Can not promote MAP type to INTEGER (state=,code=0)
> select int_primitive from array_demo;
> +----------------+
> | int_primitive |
> +----------------+
> | 0 |
> +----------------+
> 1 row selected (0.088 seconds)
> {code}
> Removing schema.name-mapping.default solves it
> {code:java}
> ALTER TABLE array_demo UNSET TBLPROPERTIES ('schema.name-mapping.default');
> select * from array_demo;
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> | array_demo.int_primitive | array_demo.int_array | array_demo.int_array_array | array_demo.int_to_array_array_map |
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> | 0 | [1] | [[2],[3,4]] | {5:[[6],[7,8]]} |
> +---------------------------+-----------------------+-----------------------------+------------------------------------+
> {code}
> Possible cause:
>
> The name mapping generated and pushed into schema.name-mapping.default is different from the name mapping in the schema in the metadata.json (attached it)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)