Re: [PR] fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… [cloudstack]

["abh1sar (via GitHub)" <gi...@apache.org>]

abh1sar commented on code in PR #12032:
URL: https://github.com/apache/cloudstack/pull/12032#discussion_r2655046462


##########
plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/hypervisor/OvmResourceBase.java:
##########
@@ -362,7 +362,7 @@ protected void setupServer() throws IOException {
 
         sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip, _username, _password);
         if (sshConnection == null) {
-            throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=%3$s", _ip, _username, _password));
+            throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=*****", _ip, _username));

Review Comment:
   ```suggestion
               throw new CloudRuntimeException(String.format("Cannot connect to ovm host(IP=%1$s, username=%2$s, password=*****)", _ip, _username));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org