[GitHub] [hive] pvary commented on a change in pull request #2847: HIVE-25788: Iceberg CTAS should honor location clause and have correct table properties

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2847:
URL: https://github.com/apache/hive/pull/2847#discussion_r764662834



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -166,22 +167,33 @@ private void createTableForCTAS(Configuration configuration, Properties serDePro
       serDeProperties.put(InputFormatConfig.PARTITION_SPEC, PartitionSpecParser.toJson(spec));
     }
 
+    // clean up the properties for table creation (so that internal serde props don't become table props)
+    Properties createProps = getCTASTableCreationProperties(serDeProperties);
+
     // create CTAS table
     LOG.info("Creating table {} for CTAS with schema: {}, and spec: {}",
         serDeProperties.get(Catalogs.NAME), tableSchema, serDeProperties.get(InputFormatConfig.PARTITION_SPEC));
-    Catalogs.createTable(configuration, serDeProperties);
+    Catalogs.createTable(configuration, createProps);
 
     // set this in the query state so that we can rollback the table in the lifecycle hook in case of failures
     SessionStateUtil.addResource(configuration, InputFormatConfig.CTAS_TABLE_NAME,
         serDeProperties.getProperty(Catalogs.NAME));
   }
 
-  private void assertNotVectorizedTez(Configuration configuration) {
-    if ("tez".equals(configuration.get("hive.execution.engine")) &&
-        "true".equals(configuration.get("hive.vectorized.execution.enabled"))) {
-      throw new UnsupportedOperationException("Vectorized execution on Tez is currently not supported when using " +
-          "Iceberg tables. Please set hive.vectorized.execution.enabled=false and rerun the query.");
-    }
+  private Properties getCTASTableCreationProperties(Properties serDeProperties) {

Review comment:
       maybe `filterCTASTableCreationProperties`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org