You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ivan Pavlukhin (JIRA)" <ji...@apache.org> on 2019/02/20 15:08:00 UTC
[jira] [Comment Edited] (IGNITE-11356) Test framework: Remove
custom assumption exceptions handling
[ https://issues.apache.org/jira/browse/IGNITE-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773088#comment-16773088 ]
Ivan Pavlukhin edited comment on IGNITE-11356 at 2/20/19 3:07 PM:
------------------------------------------------------------------
[~sergey-chugunov] I will spend some time to check if a class rule body is needed to be executed under exclusive lock. If not I will remove that logic and rename a rule class in a way reflecting it's single responsibility.
was (Author: pavlukhin):
[~sergey-chugunov] I will spend some to check if a class rule body is needed to be executed under exclusive lock. If not I will remove that logic and rename a rule class in a way reflecting it's single responsibility.
> Test framework: Remove custom assumption exceptions handling
> ------------------------------------------------------------
>
> Key: IGNITE-11356
> URL: https://issues.apache.org/jira/browse/IGNITE-11356
> Project: Ignite
> Issue Type: Task
> Reporter: Ivan Pavlukhin
> Assignee: Ivan Pavlukhin
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It turns out that custom handling of {{AssumptionViolatedException}} can be removed. Currently with custom handling tests with unmet assumptions are marked as passed. With default handling failed assumptions on instance level mark tests as ignored.
> Note: on class level reporting in case of unmet assumptions does not look perfect. But with custom handling a particular test is not included into TC report at all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)