You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 14:19:43 UTC
[GitHub] [arrow] kiszk opened a new pull request #7923: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
kiszk opened a new pull request #7923:
URL: https://github.com/apache/arrow/pull/7923
This PR fixes two test failures on BE platform by taking care of big-endian in `setBytes()` and `memcpy()`.
```
% mvn -B -Drat.skip=true -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dflatc.download.skip=true -rf :arrow-memory-core test
...
[ERROR] TestArrowBuf.testSetBytesBigEndian:145 arrays first differed at element [0]; expected:<0> but was:<7>
[ERROR] TestByteFunctionHelpers.testStringCompare Multiple Failures (2 failures)
expected:<-1> but was:<1>
...
[ERROR] Tests run: 31, Failures: 2, Errors: 0, Skipped: 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield closed pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #7923:
URL: https://github.com/apache/arrow/pull/7923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674311119
@jacques-n Good point. During the support work of the BE, I realized `UnsafeDirectLittleEndian` class can support the big endian while its class name includes `LittleEndian`.
As you pointed out, the above preconditions should be moved to another place. However, I am not sure where is the best place of this pre-condition. Do you have any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674313247
At my end, I have another change to `DecimalVector` class that depends on LE. I have not submitted it yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674312725
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk edited a comment on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
kiszk edited a comment on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674311119
@jacques-n Good point. During the support work of the BE, I realized `UnsafeDirectLittleEndian` class can support the big-endian while its class name includes `LittleEndian`. Other places that I am addressing depend on the LE.
As you pointed out, the above preconditions should be moved to another place. However, I am not sure where is the best place of this pre-condition. Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-673875225
+1 thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-671385940
https://issues.apache.org/jira/browse/ARROW-9681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674311623
> By design, the Arrow Java library specifically excluded support for big-endian systems
I started a thread on the ML about Big Endian in Java, lets have the conversation there if we don't think we want to support this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jacques-n commented on pull request #7923: ARROW-9681: [Java] Fix test failures of Arrow Memory - Core on big-endian platform
Posted by GitBox <gi...@apache.org>.
jacques-n commented on pull request #7923:
URL: https://github.com/apache/arrow/pull/7923#issuecomment-674303879
Hmm... I'm not sure we should have accepted this patch. By design, the Arrow Java library specifically excluded support for big-endian systems. It seems like we need to move the preconditions check further up the stack now that you don't have to use the Netty allocator.
https://github.com/apache/arrow/blob/2092e18752a9c0494799493b12eb1830052217a2/java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java#L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org