You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "joerghoh (via GitHub)" <gi...@apache.org> on 2026/07/21 13:34:13 UTC
[PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
joerghoh opened a new pull request, #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050
just additional diagnostic data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050#issuecomment-5143317732
## [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=3050)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "cschneider (via GitHub)" <gi...@apache.org>.
cschneider commented on PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050#issuecomment-5163839385
Many thanks. Looking forward to seeing this information in the stack traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050#discussion_r3685727227
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##########
@@ -303,16 +303,29 @@ private StringBuilder buildAfterIdentifier(StringBuilder identifier) {
return identifier;
}
- private static void throwCheckedIn(String msg)
+ private void throwCheckedIn(String msg)
throws CommitFailedException {
throw new CommitFailedException(CommitFailedException.VERSION,
- VersionExceptionCode.NODE_CHECKED_IN.ordinal(), msg);
+ VersionExceptionCode.NODE_CHECKED_IN.ordinal(),
+ msg + " at " + getPath());
}
- private static void throwProtected(String name)
+ /**
+ * @return the absolute path of the node this editor is processing,
+ * reconstructed from the parent chain.
+ */
+ private String getPath() {
+ if (parent == null) {
+ return "/";
+ }
+ String parentPath = parent.getPath();
+ return parentPath.equals("/") ? "/" + name : parentPath + "/" + name;
+ }
+
+ private void throwProtected(String name)
throws CommitFailedException {
throw new CommitFailedException(CommitFailedException.CONSTRAINT, 100,
- "Property is protected: " + name);
+ "Property is protected: " + name + " at " + getPath());
Review Comment:
```suggestion
"Property is protected: " + name + " at '" + getPath() + "'");
```
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##########
@@ -303,16 +303,29 @@ private StringBuilder buildAfterIdentifier(StringBuilder identifier) {
return identifier;
}
- private static void throwCheckedIn(String msg)
+ private void throwCheckedIn(String msg)
throws CommitFailedException {
throw new CommitFailedException(CommitFailedException.VERSION,
- VersionExceptionCode.NODE_CHECKED_IN.ordinal(), msg);
+ VersionExceptionCode.NODE_CHECKED_IN.ordinal(),
+ msg + " at " + getPath());
Review Comment:
```suggestion
msg + " at '" + getPath() + "'");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh merged PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050#issuecomment-5034705664
# Commit-Check ✔️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12017 augment exceptions with path of affected node [jackrabbit-oak]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on PR #3050:
URL: https://github.com/apache/jackrabbit-oak/pull/3050#issuecomment-5163590857
also closes #2635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org