You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by johnament <gi...@git.apache.org> on 2014/11/28 02:22:10 UTC
[GitHub] incubator-usergrid pull request: Usergrid 248
GitHub user johnament opened a pull request:
https://github.com/apache/incubator-usergrid/pull/110
Usergrid 248
For some reason I thought I created this PR already.
This adds a distribution build for the portal so that it can be part of the apache mirrors, nexus repos, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnament/incubator-usergrid USERGRID-248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #110
----
commit 3c06eb15f8c9bf5190a8be12f0daa5aba035501f
Author: John D. Ament <jo...@apache.org>
Date: 2014-11-13T02:56:54Z
USERGRID-248 Create a package for portal distributions that can be uploaded via nexus.
commit 1d7755a8b664bb2f76ba49872d4ccf56833794d0
Author: John D. Ament <jo...@apache.org>
Date: 2014-11-13T03:00:14Z
USERGRID-248 Missed header.
commit 91ba35606b5c0bd74f92cd025038dcc35d032017
Author: John D. Ament <jo...@apache.org>
Date: 2014-11-28T01:21:04Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/incubator-usergrid
Conflicts:
.gitignore
portal/README.md
commit 16205d8b3332918a6ce20cb93064df7e983b3321
Author: John D. Ament <jo...@apache.org>
Date: 2014-11-28T01:21:15Z
Merge branch 'master' into USERGRID-248
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by rodsimpson <gi...@git.apache.org>.
Github user rodsimpson commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-66715013
John, looks great. Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-64842450
BTW, I know there's a discussion about switching branch names. This is meant to go against 1.0.1-SNAPSHOT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-66560226
Ok, i know why the grunt file is reformatted. As discussed on the mailing list, I back ported the portal packaging from 2.0 to 1.x -> https://github.com/apache/incubator-usergrid/commit/72c165e498d4d9a2dce7f440b5ff825c12f2c498
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-66559592
@rodsimpson nope, i didn't use a source formatter. I did notice the grunt file seems to have been formatted differently, but the others all look sane.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by rodsimpson <gi...@git.apache.org>.
Github user rodsimpson commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-66557089
John, sorry to be so picky, but it looks like maybe you used a source formatter? There are a lot of lines that are changed, making it hard to tell what is new and what is old.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-65226285
Issues with length should be resolved. I added a config option to allow overriding, this way the old behaviour is still around, but for those like me we can also have the new behaviour via interface.
Let me know if you have some time to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by rodsimpson <gi...@git.apache.org>.
Github user rodsimpson commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-64916029
This can't have 10K as the limit. 1K is the max results we want to send down from the stack. However, this would just be a temporary workaround as the real solution is to add paging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 248
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/110#issuecomment-64915444
Should the stack changes be in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---