You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2019/05/29 19:50:00 UTC

[jira] [Comment Edited] (CALCITE-2742) Update RexImpTable to user DataContext to retrieve USER and SYSTEM_USER

    [ https://issues.apache.org/jira/browse/CALCITE-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851254#comment-16851254 ] 

Julian Hyde edited comment on CALCITE-2742 at 5/29/19 7:49 PM:
---------------------------------------------------------------

Reviewing PR 1031 now it has been rebased.

[~siddteotia] One question: is the "Optional" stuff necessary? We can assume that USER and SYSTEM_USER are set in DataContext, right? I don't like over-defensive programming.


was (Author: julianhyde):
Reviewing PR 1031 now it has been rebased.

One question: is the "Optional" stuff necessary? We can assume that USER and SYSTEM_USER are set in DataContext, right? I don't like over-defensive programming.

> Update RexImpTable to user DataContext to retrieve USER and SYSTEM_USER
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-2742
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2742
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Jacques Nadeau
>            Assignee: Jacques Nadeau
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> Right now, USER and SYSTEM_USER are hardcoded to "sa" and the system property of user.name. Let's update them to use the DataContext system like the other similar types of values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)