You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/13 03:05:34 UTC
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #3733: Encrypt select statement in operator
tristaZero commented on a change in pull request #3733: Encrypt select statement in operator
URL: https://github.com/apache/incubator-shardingsphere/pull/3733#discussion_r357468378
##########
File path: sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/pojo/EncryptPredicateRightValueToken.java
##########
@@ -72,7 +72,6 @@ private String toStringForEqual() {
private String toStringForIn() {
StringBuilder result = new StringBuilder();
- result.append("(");
Review comment:
Can we fix this bug by modifying the startIndex? By reviewing the unit test, personally it seems wired that `toStringForIn()` returns `'a', 'b')`, and `('a', 'b')` is complete string item. How about you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services