You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/17 17:25:29 UTC

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4306: Fix omitempty issue for ATS config metadata generation

rawlinp opened a new pull request #4306: Fix omitempty issue for ATS config metadata generation
URL: https://github.com/apache/trafficcontrol/pull/4306
 
 
   ## What does this PR (Pull Request) do?
   If empty, the 'url' and 'apiUri' fields should be omitted from the marshalled JSON, which is how Perl handled it. This fixes ORT's ability to use "URL" parameters which ORT fetches places them on the filesystem like config files. Without this fix, ORT requests `https://mytrafficops.example.com/` since `apiUri == ""` instead of the given URL in the parameter.
   
   - [x] This PR fixes #4299 
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   - Traffic Ops ORT
   
   No docs or changelog necessary since this just fixes a regression in the API.
   
   ## What is the best way to verify this PR?
   Run the Go unit tests (`go test ./lib/... ./traffic_ops/traffic_ops_golang/... ./traffic_monitor/... ./traffic_stats/... ./grove/... ./traffic_ops/ort/atstccfg/...`) and make sure they all pass.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0.0-RC1
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4306: Fix omitempty issue for ATS config metadata generation

Posted by GitBox <gi...@apache.org>.
mhoppa commented on issue #4306: Fix omitempty issue for ATS config metadata generation
URL: https://github.com/apache/trafficcontrol/pull/4306#issuecomment-576738979
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #4306: Fix omitempty issue for ATS config metadata generation

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #4306: Fix omitempty issue for ATS config metadata generation
URL: https://github.com/apache/trafficcontrol/pull/4306
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services